Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add editor slice #5682

Merged
merged 2 commits into from
Nov 22, 2023
Merged

front: add editor slice #5682

merged 2 commits into from
Nov 22, 2023

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Nov 14, 2023 •
edited
Loading

closes #5299

  • Replace editor reducer by the slice
  • add test of editor state

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (9eee792) 19.52% compared to head (7f7d363) 19.50%.
Report is 22 commits behind head on dev.

Files Patch % Lines
front/src/reducers/editor/index.ts 86.36% 5 Missing and 4 partials ⚠️
front/src/reducers/editor/selectors.ts 0.00% 4 Missing and 1 partial ⚠️
.../editor/components/InfraErrors/InfraErrorsList.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5682      +/-   ##
============================================
- Coverage     19.52%   19.50%   -0.02%     
  Complexity     2327     2327              
============================================
  Files           907      907              
  Lines        106965   106944      -21     
  Branches       2590     2587       -3     
============================================
- Hits          20881    20863      -18     
  Misses        84558    84558              
+ Partials       1526     1523       -3
Flag Coverage Δ
front 8.39% <79.48%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anisometropie
anisometropie requested changes Nov 14, 2023
View reviewed changes
front/src/reducers/editor/selectors.ts Outdated Show resolved Hide resolved
front/src/reducers/editor/index.ts Show resolved Hide resolved
clarani
clarani reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 🙏
Left some small comments

front/src/reducers/editor/index.ts Outdated Show resolved Hide resolved
front/src/reducers/editor/index.ts Show resolved Hide resolved
front/src/reducers/editor/__tests__/editorReducer.spec.ts Outdated Show resolved Hide resolved
front/src/reducers/editor/__tests__/editorReducer.spec.ts Outdated Show resolved Hide resolved
@Uriel-Sautron Uriel-Sautron marked this pull request as ready for review November 21, 2023 15:03
@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner November 21, 2023 15:03
clarani
clarani approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested the editor in local, everything seems to work ✅

Only left one last suggestion

front/src/reducers/editor/__tests__/editorReducer.spec.ts Outdated Show resolved Hide resolved
@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit d3cb83c Nov 22, 2023
6 of 7 checks passed
@Uriel-Sautron Uriel-Sautron deleted the cnh/slice-editor-5299 branch November 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uriel-Sautron Uriel-Sautron Uriel-Sautron left review comments

@clarani clarani clarani approved these changes

@anisometropie anisometropie anisometropie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: slice editeur
4 participants
@kmer2016 @anisometropie @clarani @Uriel-Sautron